docs: remove chat:write.public scope for best practice#281
Merged
Conversation
mwbrooks
added
code health
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 64.87% 64.85% -0.02%
==========================================
Files 212 212
Lines 17538 17538
==========================================
- Hits 11378 11375 -3
- Misses 5094 5095 +1
- Partials 1066 1068 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
approved these changes
Dec 3, 2025
Comment on lines
-329
to
-330
| text: `{"ok":true,"app_id":"A123","credentials":{"client_id":"123","client_secret":"123","verification_token":"123","signing_secret":"123"},"oauth_authorize_url":"123":\/\/slack.com\/oauth\/v2\/authorize?client_id=123&scope=commands,chat:write,chat:write.public"}`, | ||
| expected: `{"ok":true,"app_id":"A123","credentials":{"client_id":"...","client_secret":"...","verification_token":"...","signing_secret":"..."},"oauth_authorize_url":"...":\/\/slack.com\/oauth\/v2\/authorize?client_id=...&scope=commands,chat:write,chat:write.public"}`, |
Member
There was a problem hiding this comment.
🧪 thought: This might reduce the quality of these tests in some perhaps odd edge cases but let's not let that block these greps!
Member
Author
|
@zimeg Thanks for the quick review in contrast to my super slow response! 😬 Hopefully this doesn't degrade our test quality, but we can always revisit it. 🙇🏻 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request removes references to the
chat:write.publicscope to encourage best practices since this scope is more permissive and should be used sparingly.This change was originally proposed by @GPTI314 in PR #267. Since the PR is inactive and the CLA is not signed, I've re-written it in this PR.
Requirements